-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graceful stop specs #6103
Merged
Aaronontheweb
merged 3 commits into
akkadotnet:dev
from
Aaronontheweb:add-GracefulStopSpecs
Sep 17, 2022
Merged
Add graceful stop specs #6103
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
//----------------------------------------------------------------------- | ||
// <copyright file="GracefulStopSpecs.cs" company="Akka.NET Project"> | ||
// Copyright (C) 2009-2022 Lightbend Inc. <http://www.lightbend.com> | ||
// Copyright (C) 2013-2022 .NET Foundation <https://github.com/akkadotnet/akka.net> | ||
// </copyright> | ||
//----------------------------------------------------------------------- | ||
|
||
using System; | ||
using System.Threading.Tasks; | ||
using Akka.Actor; | ||
using Akka.Actor.Dsl; | ||
using Akka.TestKit; | ||
using Akka.TestKit.TestActors; | ||
using Xunit; | ||
using FluentAssertions; | ||
|
||
namespace Akka.Tests.Actor | ||
{ | ||
public class GracefulStopSpecs : AkkaSpec | ||
{ | ||
[Fact(DisplayName = "GracefulStop should terminate target actor on-time")] | ||
public async Task GracefulStopShouldTerminateOnTime() | ||
{ | ||
// arrange | ||
var actor = Sys.ActorOf(BlackHoleActor.Props); | ||
Watch(actor); | ||
|
||
// act | ||
var stopped = await actor.GracefulStop(TimeSpan.FromSeconds(3)); | ||
await ExpectTerminatedAsync(actor); | ||
|
||
// assert | ||
stopped.Should().BeTrue(); | ||
} | ||
|
||
[Fact(DisplayName = "GracefulStop should return true for an already terminated actor")] | ||
public async Task GracefulStopShouldReturnTrueForAlreadyDeadActor() | ||
{ | ||
// arrange | ||
var actor = Sys.ActorOf(BlackHoleActor.Props); | ||
Watch(actor); | ||
|
||
// act | ||
Sys.Stop(actor); | ||
await ExpectTerminatedAsync(actor); | ||
var stopped = await actor.GracefulStop(TimeSpan.FromSeconds(3)); | ||
|
||
// assert | ||
stopped.Should().BeTrue(); | ||
} | ||
|
||
private class CustomShutdown{} | ||
|
||
[Fact(DisplayName = "GracefulStop should return false if shutdown goes overtime", Skip = "GracefulStop currently throws a TaskCancellationException, which seems wrong")] | ||
public async Task GracefulStopShouldThrowIfShutdownGoesOvertime() | ||
{ | ||
// arrange | ||
var actor = Sys.ActorOf(act => act.ReceiveAsync<CustomShutdown>(async (a, ctx) => | ||
{ | ||
await Task.Delay(200); | ||
ctx.Stop(ctx.Self); | ||
})); | ||
|
||
// act | ||
var stopped = await actor.GracefulStop(TimeSpan.FromMilliseconds(10), new CustomShutdown()); | ||
|
||
// assert | ||
stopped.Should().BeFalse(); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked this test as
Skipped
for now - going to change that in #6102This API is wrong. We shouldn't throw an
Exception
if graceful stop fails to complete on-time - we should simply returnfalse
. Otherwise there's no point to having a return value at all.