Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akka.TestKit: accidental breaking changes in v1.5.0-beta3 #6466

Closed
3 tasks done
Aaronontheweb opened this issue Feb 28, 2023 · 1 comment
Closed
3 tasks done

Akka.TestKit: accidental breaking changes in v1.5.0-beta3 #6466

Aaronontheweb opened this issue Feb 28, 2023 · 1 comment
Labels
akka-testkit Akka.NET Testkit issues confirmed bug
Milestone
1.5.0

Comments

@Aaronontheweb
Copy link
Member

Aaronontheweb commented Feb 28, 2023 •
edited
Loading

Version Information
Version of Akka.NET? v1.5.0-beta3
Which Akka.NET Modules? All TestKit distributions.

Describe the bug

The following API signatures were broken by accident - and we should add them back before v1.5 ships:

  • ExpectMsgAllOf used to accept params object[] - no longer does.
  • AwaitConditionAsync used to accept a Func<bool> - now it only accepts a Func<Task<bool>>; should still accept both.
  • ExpectOneAsync used to accept an Action - now it only accepts Func<Task>
@Aaronontheweb Aaronontheweb added confirmed bug akka-testkit Akka.NET Testkit issues labels Feb 28, 2023
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Feb 28, 2023
@Aaronontheweb Aaronontheweb mentioned this issue Feb 28, 2023
Merged
5 tasks
@Aaronontheweb
Copy link
Member Author

closed via #6467

@Aaronontheweb Aaronontheweb mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
akka-testkit Akka.NET Testkit issues confirmed bug
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@Aaronontheweb