Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DData Max-Delta-Elements may not be fully honoured #5157

Closed
andyfurnival opened this issue Jul 26, 2021 · 3 comments · Fixed by #5163
Closed

DData Max-Delta-Elements may not be fully honoured #5157

andyfurnival opened this issue Jul 26, 2021 · 3 comments · Fixed by #5163
Assignees
Milestone

Comments

@andyfurnival
Copy link
Contributor

Version Information
Version of Akka.NET?
1.4.21
Which Akka.NET Modules?
Akka.DistributedData

Describe the bug
I believe the max-delta-elements will not be fully respected due to the operator used. Since this is greater than or equal to max-delta-elements, when it hits max elements it will discard the delta update. I think it should honour the max elements, and discard for any amount over. This is how Distributed Pub Sub seems to behave

To Reproduce

if (merged is IReplicatedDeltaSize s && s.DeltaSize >= MaxDeltaSize)

Links to working reproductions on Github / Gitlab are very much appreciated

Expected behavior
It should be just using greater than >

Actual behavior
Its using >=

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Are you running on Linux? Windows? Docker? Which version of .NET?
Linux

Additional context
I have a PR ready to go if you agree this needs amending (didn't want to just assume a change was required)

@Aaronontheweb
Copy link
Member

@Arkatufus care to take this one onto the triage list?

@Arkatufus
Copy link
Contributor

@Aaronontheweb
Copy link
Member

We think the original Scala code is probably wrong in this regard too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants