From 2ea4797d445c484bd2125ed45058e2311cfaed9f Mon Sep 17 00:00:00 2001 From: Ismael Hamed <1279846+ismaelhamed@users.noreply.github.com> Date: Wed, 11 May 2022 07:45:36 +0200 Subject: [PATCH] Renamed method `SetHandler` accepting both callbacks to `SetHandlers` --- .../verify/CoreAPISpec.ApproveStreams.Core.verified.txt | 2 ++ .../CoreAPISpec.ApproveStreams.DotNet.verified.txt | 2 ++ .../verify/CoreAPISpec.ApproveStreams.Net.verified.txt | 2 ++ src/core/Akka.Streams/Stage/GraphStage.cs | 9 ++++++++- 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Core.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Core.verified.txt index f5ea9a0ead2..31c922274a5 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Core.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Core.verified.txt @@ -4760,7 +4760,9 @@ namespace Akka.Streams.Stage protected void SetHandler(Akka.Streams.Inlet inlet, System.Action onPush, System.Action onUpstreamFinish = null, System.Action onUpstreamFailure = null) { } protected void SetHandler(Akka.Streams.Outlet outlet, Akka.Streams.Stage.IOutHandler handler) { } protected void SetHandler(Akka.Streams.Outlet outlet, System.Action onPull, System.Action onDownstreamFinish = null) { } + [System.ObsoleteAttribute("Use method `SetHandlers` instead. Will be removed in v1.5")] protected void SetHandler(Akka.Streams.Inlet inlet, Akka.Streams.Outlet outlet, Akka.Streams.Stage.InAndOutGraphStageLogic handler) { } + protected void SetHandlers(Akka.Streams.Inlet inlet, Akka.Streams.Outlet outlet, Akka.Streams.Stage.InAndOutGraphStageLogic handler) { } protected void SetKeepGoing(bool enabled) { } protected void TryPull(Akka.Streams.Inlet inlet) { } protected sealed class LambdaInHandler : Akka.Streams.Stage.InHandler diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.DotNet.verified.txt index 2e1adae5eef..bdb0ca4cd1d 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.DotNet.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.DotNet.verified.txt @@ -4771,7 +4771,9 @@ namespace Akka.Streams.Stage protected void SetHandler(Akka.Streams.Inlet inlet, System.Action onPush, System.Action onUpstreamFinish = null, System.Action onUpstreamFailure = null) { } protected void SetHandler(Akka.Streams.Outlet outlet, Akka.Streams.Stage.IOutHandler handler) { } protected void SetHandler(Akka.Streams.Outlet outlet, System.Action onPull, System.Action onDownstreamFinish = null) { } + [System.ObsoleteAttribute("Use method `SetHandlers` instead. Will be removed in v1.5")] protected void SetHandler(Akka.Streams.Inlet inlet, Akka.Streams.Outlet outlet, Akka.Streams.Stage.InAndOutGraphStageLogic handler) { } + protected void SetHandlers(Akka.Streams.Inlet inlet, Akka.Streams.Outlet outlet, Akka.Streams.Stage.InAndOutGraphStageLogic handler) { } protected void SetKeepGoing(bool enabled) { } protected void TryPull(Akka.Streams.Inlet inlet) { } protected sealed class LambdaInHandler : Akka.Streams.Stage.InHandler diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt index f5ea9a0ead2..31c922274a5 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt @@ -4760,7 +4760,9 @@ namespace Akka.Streams.Stage protected void SetHandler(Akka.Streams.Inlet inlet, System.Action onPush, System.Action onUpstreamFinish = null, System.Action onUpstreamFailure = null) { } protected void SetHandler(Akka.Streams.Outlet outlet, Akka.Streams.Stage.IOutHandler handler) { } protected void SetHandler(Akka.Streams.Outlet outlet, System.Action onPull, System.Action onDownstreamFinish = null) { } + [System.ObsoleteAttribute("Use method `SetHandlers` instead. Will be removed in v1.5")] protected void SetHandler(Akka.Streams.Inlet inlet, Akka.Streams.Outlet outlet, Akka.Streams.Stage.InAndOutGraphStageLogic handler) { } + protected void SetHandlers(Akka.Streams.Inlet inlet, Akka.Streams.Outlet outlet, Akka.Streams.Stage.InAndOutGraphStageLogic handler) { } protected void SetKeepGoing(bool enabled) { } protected void TryPull(Akka.Streams.Inlet inlet) { } protected sealed class LambdaInHandler : Akka.Streams.Stage.InHandler diff --git a/src/core/Akka.Streams/Stage/GraphStage.cs b/src/core/Akka.Streams/Stage/GraphStage.cs index 8659b2ef729..22d3bc2a5af 100644 --- a/src/core/Akka.Streams/Stage/GraphStage.cs +++ b/src/core/Akka.Streams/Stage/GraphStage.cs @@ -972,7 +972,14 @@ protected internal void SetHandler(Outlet outlet, Action onPull, Action on /// /// Assigns callbacks for the events for an and . /// - protected internal void SetHandler(Inlet inlet, Outlet outlet, InAndOutGraphStageLogic handler) + [Obsolete("Use method `SetHandlers` instead. Will be removed in v1.5")] + protected internal void SetHandler(Inlet inlet, Outlet outlet, InAndOutGraphStageLogic handler) => + SetHandlers(inlet, outlet, handler); + + /// + /// Assigns callbacks for the events for an and . + /// + protected internal void SetHandlers(Inlet inlet, Outlet outlet, InAndOutGraphStageLogic handler) { SetHandler(inlet, handler); SetHandler(outlet, handler);