Revert "Use short assembly name during serialization to avoid versioning problems" #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28. During the process of targeting .NET Standard 1.6, we found that the signature being used for
Type.GetTypein this PR isn't available in netstandard1.6. We made an attempt to use compiler directives to enable this feature for net45 compilation only, but there is the potential for inconsistent wire format across netstandard1.6 and net45 versions of the assembly if we do that. Plan is to get .NET Core up and running and then come back to making this feature compatible with netstandard1.6.