Fix disallow-unsafe-type Akka.NET settings and harden unsafe type detection #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ufus/Hyperion into Fix_Allow_unsafe_type_still_throws
Arkatufus
commented
Mar 22, 2022
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public static bool IsDisallowedType(string name) | ||
| => UnsafeTypesDenySet.Any(name.Contains); |
There was a problem hiding this comment.
Refactored this out of the method so we can use it in unit tests
Arkatufus
commented
Mar 22, 2022
| @@ -208,16 +226,16 @@ public static Type LoadTypeByName(string name, bool disallowUnsafeTypes, ITypeFi | |||
| // i.e. if there are different version available in GAC and locally | |||
| var typename = ToQualifiedAssemblyName(name, ignoreAssemblyVersion: false); | |||
| var type = Type.GetType(typename, true); | |||
| if (UnsafeInheritanceCheck(type)) | |||
| if (disallowUnsafeTypes && UnsafeInheritanceCheck(type)) | |||
There was a problem hiding this comment.
This is the bug, disallowed types are checked several times, this line need to be bypassed if unsafe types are allowed
Arkatufus
commented
Mar 22, 2022
| var type = Type.GetType(typename, true); | ||
| if (UnsafeInheritanceCheck(type)) | ||
| var type = Type.GetType(typename, true); | ||
| if (disallowUnsafeTypes && UnsafeInheritanceCheck(type)) |
There was a problem hiding this comment.
This is the bug, disallowed types are checked several times, this line need to be bypassed if unsafe types are allowed
Arkatufus
commented
Mar 22, 2022
| @@ -25,6 +34,73 @@ public void CantDeserializeANaughtyType() | |||
| } | |||
| } | |||
|
|
|||
| [Theory] | |||
| [MemberData(nameof(DangerousObjectFactory))] | |||
| public void DetectNaughtyTypesByDefault(Type dangerousType) | |||
There was a problem hiding this comment.
Detection hardening unit test, actually try to use the dangerous types and see if they are being caught by the default filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes akkadotnet/akka.net#5740