Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3: Include custom headers in all multipart copy requests #2844

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

jfromme
Copy link
Contributor

@jfromme jfromme commented Mar 23, 2022

This PR addresses the issue referenced below by ensuring that custom S3 headers passed to multipart copy are included when copying parts and in the final completion request.

References #2839

@ennru ennru added the p:aws-s3 label Mar 23, 2022
@ennru
Copy link
Member

ennru commented Mar 24, 2022

Thank you for this PR. CI didn't kick in properly.
Could you rebase this as I've just merged #2842 which switches to use Testcontainers for the AWS S3 module, please?

@jfromme jfromme force-pushed the mulitpart-copy-custom-headers branch from 13f6a35 to 180feaf Compare March 24, 2022 14:47
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title AWS S3: Include custom headers in all requests associated with a multipart copy AWS S3: Include custom headers in all multipart copy requests Mar 25, 2022
@ennru ennru merged commit a4dacc6 into akka:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants