S3: Make eTag naming consistent #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
commented
Oct 2, 2021
| @@ -89,13 +99,13 @@ object MultipartUploadResult { | |||
| location: Uri, | |||
| bucket: String, | |||
| key: String, | |||
| etag: String, | |||
| eTag: String, | |||
There was a problem hiding this comment.
AFAIK this can break source compatibility (i.e. if someone calls apply with named parameters specifically within Scala) but it doesn't break binary compatibility.
mdedetrich
commented
Oct 2, 2021
| @@ -104,13 +114,13 @@ object MultipartUploadResult { | |||
| location: akka.http.javadsl.model.Uri, | |||
| bucket: String, | |||
| key: String, | |||
| etag: String, | |||
| eTag: String, | |||
There was a problem hiding this comment.
AFAIK this can break source compatibility (i.e. if someone calls create with named parameters specifically within Scala) but it doesn't break binary compatibility.
ennru
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Mima on Travis is happy with your changes https://app.travis-ci.com/github/akka/alpakka/jobs/540918111
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to make
eTag/ETagconsistent. This was done with internal private API but also the public API whereMultipartUploadResultusedetag/getEtag/getEtagwhere as every other public model usedeTag/getETag/withETag. Since this is a public API I addeddeprecatedmethods so that people are warned when using the old inconsistent etag naming and to maintain binary compatibility.There is one case where (I think) source compatibility is broken but NOT binary compatibility (see comments). Unfortunately I couldn't get mima running in Alpakka to verify this, I am getting the following error when I run
s3 / mimaReportBinaryIssues