-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate SQL Server Schemas to NVARCHAR #652
Conversation
Re: docs, I'm not sure where a "if using a journal/snapshot store created with Akka Persistence versions 5.0.4 and earlier, it is advised to disable the JDBC client's sending strings as unicode" note should go. |
Thoughts on restructuring the docs along the lines of the Cassandra plugin with notes for the different DBs? |
We should document a recommendation if using the old ( To my knowledge it's not a simple migration from the old schema to the new schema, and as far as Slick is concerned it's the same schema (in that the JVM types each column maps to are unchanged). |
Actually I guess we can support offline migration of data from an old journal/snapshot-store to a new journal/snapshot-store, but I think it would be generally preferable from the user perspective to use the old schema and configure JDBC to work properly with the old schema. That said, the migration tool would support the "turns out, we need unicode persistence IDs or tags" use case. |
@leviramsey would it be possible to push this forward? |
I guess the question is if we want to implement a migration tool (which honestly is not something I'm confident on being able to implement any time soon). As it is, this should just be mergeable (it requires no code changes, AFAIK), perhaps with docs around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We don't need to provide a migration tool. DBAs (or any developer with some google skills) can do that with SQL.
Only a small addition of the version numbers.
References #650