-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make generated code look nicer? #368
Comments
I'm not sure it is a good idea, we also need to maintain that template, and flattening it to make the generated code "normal" makes the template very hard to read. |
Perhaps related to playframework/twirl#141 ? |
Yeah, if twirl could output something that looks nice without much tweaking the template source that would be awesome. |
Here are the steps I used to have a look at this (thanks @raboof for the help!):
Given playframework/twirl#169 I tried upgrade sbt-twirl to 1.3.14, but private val sayHelloRequestBuilder = {
new ScalaUnaryRequestBuilder(sayHelloDescriptor, channel, options, settings)
} /cc @mkurz who authored the change in twirl. Do you know why the indentation isn't fixed? |
Because of the loops in our templates, the whitespace in the generated code is quite jumbled-up.
Since people may be looking at the generated code, it might be worth it to tweak some things to make the generated code look neater at the cost of making the templates less easily readable.
The text was updated successfully, but these errors were encountered: