Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goneovim setting.toml to settings.toml #481

Open
vabenil opened this issue Jun 18, 2023 · 3 comments
Open

Goneovim setting.toml to settings.toml #481

vabenil opened this issue Jun 18, 2023 · 3 comments

Comments

@vabenil
Copy link

vabenil commented Jun 18, 2023

It seems since v0.6.5 goneovim reads settings from settings.toml instead of setting.toml. When I updated smooth scrolling and other features stopped working and it seems it was because of this change.

After moving setting.toml to settings.toml the issue was solved but since I did not see mention of this anywhere else I decided to post the issue here.

Suggestion

Maybe it would be a good idea to create a default settings.toml if none is found.

@akiyosi
Copy link
Owner

akiyosi commented Jun 20, 2023

Hi, Thanks for this issue report.

Currently goneovim has a behavior specification that reads settings.toml if setting.toml does not exist.
This is due to the need for a transition period related to the specification when changing the config file name from setting.toml to settings.toml in the past.
I imagine that this may have surfaced in your environment because v0.6.5 changed the specification regarding the location of the Windows settings file.

I will remove the setting.toml loading process in v0.6.6.

@vabenil
Copy link
Author

vabenil commented Jun 20, 2023

So in 0.6.5 it should still continue working even if the settings file is named setting.json?
Also I am using Arch Linux not Windows.

@akiyosi
Copy link
Owner

akiyosi commented Jun 20, 2023

Yes.
Maybe if you use HEAD, there will be a fix somewhere in the future, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants