From 2d705695af742a0db9940a0ca72e341d792fcae9 Mon Sep 17 00:00:00 2001
From: Yoav Farhi <yoav@farhi.org>
Date: Tue, 12 Apr 2016 10:11:45 +0300
Subject: [PATCH 1/2] Deprecate `gp_translation_set_filters` hook in favor of
 `gp_translation_set_sort_form`, and add `gp_translation_set_filters_form`

`gp_translation_set_filters` name is wrong, since it runs after the sort options, and doesn'd allow modification of the filters form
---
 gp-templates/translations.php | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/gp-templates/translations.php b/gp-templates/translations.php
index 84d226622..cd62be4ce 100644
--- a/gp-templates/translations.php
+++ b/gp-templates/translations.php
@@ -121,7 +121,16 @@
 			<input type="checkbox" name="filters[with_context]" value="yes" id="filters[with_context][yes]" <?php gp_checked( 'yes' == gp_array_get( $filters, 'with_context' ) ); ?>><label for='filters[with_context][yes]'><?php _e( 'With context', 'glotpress' ); ?></label><br />
 			<input type="checkbox" name="filters[case_sensitive]" value="yes" id="filters[case_sensitive][yes]" <?php gp_checked( 'yes' == gp_array_get( $filters, 'case_sensitive' ) ); ?>><label for='filters[case_sensitive][yes]'><?php _e( 'Case sensitive', 'glotpress' ); ?></label>
 		</dd>
+		<?php
 
+		/**
+		 * Fires after the translation set filters options.
+		 *
+		 * This action is inside a DL element.
+		 *
+		 * @since 2.1.0
+		 */
+		do_action( 'gp_translation_set_filters_form' ); ?>
 
 		<dd><input type="submit" value="<?php esc_attr_e( 'Filter', 'glotpress' ); ?>" name="filter" /></dd>
 	</dl>
@@ -164,10 +173,19 @@
 		 * Fires after the translation set sort options.
 		 *
 		 * This action is inside a DL element.
-		 *
+		 * @deprecated 2.1.0 Call gp_translation_set_sort_form instead
 		 * @since 1.0.0
 		 */
-		do_action( 'gp_translation_set_filters' ); ?>
+		do_action( 'gp_translation_set_filters' );
+
+		/**
+		* Fires after the translation set sort options.
+		*
+		* This action is inside a DL element.
+		* @since 2.1.0
+		*/
+		do_action( 'gp_translation_set_sort_form' ); ?>
+
 		<dd><input type="submit" value="<?php esc_attr_e( 'Sort', 'glotpress' ); ?>" name="sorts" /></dd>
 	</dl>
 </form>

From 182b82825b1271f0b95b45eebf050daa9560382a Mon Sep 17 00:00:00 2001
From: Yoav Farhi <yoav@farhi.org>
Date: Tue, 12 Apr 2016 10:50:25 +0300
Subject: [PATCH 2/2] spacing

---
 gp-templates/translations.php | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gp-templates/translations.php b/gp-templates/translations.php
index cd62be4ce..8667d1f5b 100644
--- a/gp-templates/translations.php
+++ b/gp-templates/translations.php
@@ -173,17 +173,19 @@
 		 * Fires after the translation set sort options.
 		 *
 		 * This action is inside a DL element.
+		 *
 		 * @deprecated 2.1.0 Call gp_translation_set_sort_form instead
 		 * @since 1.0.0
 		 */
 		do_action( 'gp_translation_set_filters' );
 
 		/**
-		* Fires after the translation set sort options.
-		*
-		* This action is inside a DL element.
-		* @since 2.1.0
-		*/
+		 * Fires after the translation set sort options.
+		 *
+		 * This action is inside a DL element.
+		 *
+		 * @since 2.1.0
+		 */
 		do_action( 'gp_translation_set_sort_form' ); ?>
 
 		<dd><input type="submit" value="<?php esc_attr_e( 'Sort', 'glotpress' ); ?>" name="sorts" /></dd>