Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

Call language change listeners in all updated activities #7

Closed
wants to merge 1 commit into from

Conversation

vhiribarren
Copy link
Contributor

Hi,

I need to know why a back stack activity is recreated.

Unless I did a mistake, it seems that onBeforeLocaleChanged and onAfterLocaleChanged are called only in the activity where setLanguage is called, and not in all back stack activities that are recreated due to this call.

So I propose to change 2 lines and always call notifyLanguageChanged() for all back stack activities if there is a language update.

It seems to work fine in my case.

Copy link
Owner

@akexorcist akexorcist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bad, thanks!

@akexorcist
Copy link
Owner

Thanks! I merged to develop branch to test then release in 1.2.4

@akexorcist akexorcist closed this Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants