Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Private Registries in Cloudmos and AkashJS #168

Closed
2 tasks
anilmurty opened this issue Apr 23, 2024 · 0 comments
Closed
2 tasks

Add support for Private Registries in Cloudmos and AkashJS #168

anilmurty opened this issue Apr 23, 2024 · 0 comments
Assignees
@Redm4x @ygrishajev @baktun14
Labels
enhancement New feature or request P1 priority 1 feature/ enhancement

Comments

@anilmurty
Copy link

Support for private registries (with GH authentication) has been added akash-network/node@6e68af0

We need to support this in the client. Two things necessary for this:

  • Add support for validating that the credentials for requesting a privately stored container image are specified correctly in the SDL. Here are examples of good and bad SDLs:
    • good: sdl/_testdata/v2.1-credentials.yaml
    • bad: sdl/_testdata/v2.1-credentials-error.yaml
  • Add support for being able to specify GH credentials when creating deployments programmatically using AkashJS as well
@anilmurty anilmurty changed the title Add support for Private Registries Add support for Private Registries in Cloudmos and AkashJS Apr 23, 2024
@anilmurty anilmurty moved this to Up Next (prioritized) in Core Product and Engineering Roadmap Apr 23, 2024
@baktun14 baktun14 added P1 priority 1 feature/ enhancement enhancement New feature or request labels Apr 30, 2024
@baktun14 baktun14 mentioned this issue Apr 30, 2024
Closed
@baktun14 baktun14 moved this from Up Next (prioritized) to In Test (or staging) in Core Product and Engineering Roadmap May 2, 2024
@ygrishajev ygrishajev moved this from In Test (or staging) to In Progress (prioritized) in Core Product and Engineering Roadmap May 8, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
feat(sdl): implement sdl services image credentials
9d8e413 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
feat(sdl): implement sdl services image credentials
6ce2a4b 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
feat(sdl): implement service image credentials
8497004 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
test(sdl): cover service image credentials
eb7ee8e 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
refactor(sdl): change validation error name
cdc7380 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
refactor(sdl): change validation error name
7540f0f 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
refactor(sdl): improve test yml interpolation
24baa51 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
refactor(sdl): improve test yml interpolation
56059cb 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
@ygrishajev
refactor(sdl): improve test yml interpolation
571960f 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
refactor(sdl): improve test yml interpolation
ca99fb8 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
feat(sdl): implement service image credentials
06a73e8 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
test(sdl): cover service image credentials
7232f08 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
refactor(sdl): change validation error name
b7209b5 
refs akash-network/console#168
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
refactor(sdl): improve test yml interpolation
e5332e9 
refs akash-network/console#168
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 10, 2024
@semantic-release-bot
chore(release): 0.8.0 [skip ci]
c8bb80f 
## [0.8.0](v0.7.1...v0.8.0) (2024-05-10)

### Features

* **api:** move deployment relations and ip lease validation from cloudmos ([a7eb767](a7eb767)), closes [akash-network/console#133](akash-network/console#133)
* **sdl:** implement service image credentials ([06a73e8](06a73e8)), closes [akash-network/console#168](akash-network/console#168)
* **sdl:** move denom validation from cloudmos to sdl ([#133](https://github.com/akash-network/akashjs/issues/133)) ([1b5362f](1b5362f))
* **sdl:** move endpoint validation from cloudmos ([#133](https://github.com/akash-network/akashjs/issues/133)) ([0b770ec](0b770ec))
@ygrishajev ygrishajev moved this from In Progress (prioritized) to In Test (or staging) in Core Product and Engineering Roadmap May 13, 2024
@ygrishajev ygrishajev moved this from In Test (or staging) to Released (in Prod) in Core Product and Engineering Roadmap May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Redm4x Redm4x

@ygrishajev ygrishajev

@baktun14 baktun14

Labels
enhancement New feature or request P1 priority 1 feature/ enhancement
Projects
Core Product and Engineering Roadmap
Status: Released (in Prod)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Redm4x @ygrishajev @baktun14 @anilmurty