Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster continuum adjustments when fitting #340

Open
ajwheeler opened this issue Oct 7, 2024 · 0 comments
Open

Faster continuum adjustments when fitting #340

ajwheeler opened this issue Oct 7, 2024 · 0 comments
Milestone

Comments

@ajwheeler
Copy link
Owner

Right now, Korg.Fit.fit_spectrum has fit parameters that can be used to adjust for constant continuum offset and slope. This works, but a faster approach (and one that I've been using in grok prototyping) is to analytically compute the MLE for those values conditioned on the other parameters.

This would be a breaking change.

@ajwheeler ajwheeler added this to the 1.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant