Add configuration caching support to grgit. #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this. I cannot remember the reason I didn't open it but IIRC there were some backward compatibility issues with the API with this change. |
|
@ajoberstar poke :) |
|
I cherry-picked this into #354 and reworked it a little to provide two layers of plugins (to avoid requiring eager initialization). Thanks for the assistance @abelom and @runningcode! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled over https://github.com/runningcode/grgit/tree/no/config-cache which seems to be addressing something I am very interesting in. This PR is just a cherry pick of code made by @runningcode who did not PR it back then for whatever reason.
How does this conditional on gradle version approach looks? Does grgit as of today has an official minimal version of gradle or can we make it 6.1?
fix #322
See also #333