Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment, add missing semicolon [ci skip] #2479

Merged
merged 2 commits into from
May 6, 2015

Conversation

bcjordan
Copy link
Contributor

@bcjordan bcjordan commented May 1, 2015

No description provided.

@@ -679,10 +679,10 @@ var EditSession = function(text, mode) {
};

/**
* Returns an array containing the IDs of all the markers, either front or back.
* Returns an object containing the all of the markers, either front or back.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the all of the markers seems wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed! Let me know if I'll need to squash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashing would be cleaner i guess, but i usually do not ask people to do that since it requires quite some effort for fairly small benefit.

Fix extra `the`
nightwing added a commit that referenced this pull request May 6, 2015
Update comment, add missing semicolon [ci skip]
@nightwing nightwing merged commit d2dc26f into ajaxorg:master May 6, 2015
@nightwing
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants