Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex multiline search broken #5674

Open
RickStrahl opened this issue Nov 14, 2024 · 4 comments
Open

Regex multiline search broken #5674

RickStrahl opened this issue Nov 14, 2024 · 4 comments

Comments

@RickStrahl
Copy link
Contributor

RickStrahl commented Nov 14, 2024

Describe the bug

Whenever you type a \ into the find dialog it turns the search expression red and disable the search nav buttons.

image

Happens in plain mode as well as regex. As soon as you type the \ the dialog appears to show an error and becomes non-selectable. Looks like in regEx mode the count is still accurate if you add a valid regEx escape sequence.

Update: the regex multiline search \n is confirmed to be broken.

Expected Behavior

Dialog not to show in error mode.

Current Behavior

Shows in red error mode.

Reproduction Steps

Kitchen sink - default page.

Ctrl-F
Type a search expression that includes a slash

Possible Solution

No response

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

latest

@nightwing
Copy link
Member

Red means that there are no matches, it also shows 0 of 0 below. In the screenshot there are no matches because the regex is invalid, and in text mode it should be red unless there is \ in the text
Screenshot 2024-11-15 at 01 32 10

@RickStrahl
Copy link
Contributor Author

Ok, you're right - I misread that.

But with regex this happens:

image

Not it says 0 of 1 (which is wrong on both counts in this case: There should be more than 1 match and it's showing red even though it thinks there's a match)

Maybe I'm missing something about regEx search in the find because none of the \ escape sequences are working.

@whazor
Copy link
Contributor

whazor commented Nov 18, 2024

\t does find tabs for me.

But I can confirm that regex multiline search with \n does not work.

@whazor whazor changed the title Find Dialog shows error when typing a \ Regex multiline search broken Nov 18, 2024
@sekedus
Copy link

sekedus commented Nov 18, 2024

Tracking this in existing issue #2869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants