Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--generate-completion now exits with 1 #419

Closed
wbouvy opened this issue Jul 10, 2023 · 1 comment · Fixed by #423
Closed

--generate-completion now exits with 1 #419

wbouvy opened this issue Jul 10, 2023 · 1 comment · Fixed by #423

Comments

@wbouvy
Copy link

wbouvy commented Jul 10, 2023

It calls

throw PrintCompletionMessage(message)

which is a PrintMessage

class PrintCompletionMessage(message: String) : PrintMessage(message)

which now defaults to exit code 1 for some reason, even if error is false?

open class PrintMessage(
    message: String,
    statusCode: Int = 1,
    printError: Boolean = false,
) : CliktError(message, statusCode = statusCode, printError = printError)
@wbouvy
Copy link
Author

wbouvy commented Jul 10, 2023

I'd be happy to submit a PR changing the default to 0, but I'm not sure what all the side effects would be, so I figured I'd make an issue first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant