Simplify Dockerfile and narrow context #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
chore/simplify-dockerfile
branch
from
4578893
to
0783c19
Compare
Deploying with
|
| Latest commit: |
0ecb0e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9a7c7fdd.karapace.pages.dev |
| Branch Preview URL: | https://chore-simplify-dockerfile.karapace.pages.dev |
aiven-anton
force-pushed
the
chore/simplify-dockerfile
branch
from
0783c19
to
4d2a477
Compare
7 tasks
- Use cache mounts for pip and apt, heavily reducing network requests when cache is warm. - Remove git as a build-time dependency, other than switching to archive endpoints as was done in 39b4f08, this also requires either setting `KARAPACE_VERSION` as container build arg or building karapace/version.py independently. - Add hadolint pre-commit check for linting Dockerfile. - Pin all apt dependencies (hadolint rule).
aiven-anton
force-pushed
the
chore/simplify-dockerfile
branch
from
4d2a477
to
0ecb0e0
Compare
- Move to using Python base images for builder and final stage. This allows omitting installation of some build tools. It also allows moving to a more recent Python version, no longer being bound by what's in distro repositories. Wheel availability of some of our Python dependencies prevents us from moving to 3.11 for now. - Change installation approach to construct a virtualenv in the builder step, and copying it unaltered to the final stage, with dependencies and Karapace itself installed in it. This allows having even fewer layers in the final stage, and is simpler. - Introduces a _much_ stricter .dockerignore, ignoring files by default and explicitly including what's required. This makes sure changes in unrelated files does not evict layer cache. For example, a few files that previously erroneously evicted caches, because everything was included: - .git/* - .mypy_cache/* - container/Dockerfile itself - __pycache__/* - .idea/*
aiven-anton
force-pushed
the
chore/simplify-dockerfile
branch
from
0ecb0e0
to
88be2f7
Compare
aiven-anton
force-pushed
the
chore/optimize-container-build
branch
from
0e0ce92
to
793e204
Compare
|
Closed in favor of #579. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
.git/*.mypy_cache/*container/Dockerfileitself__pycache__/*.idea/*Image size remains the about the same as previously, but slightly reduced (the
karapace-devtag is the new version):