-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce multi-arch builds with support for ARM #578
Conversation
Deploying with Cloudflare Pages
|
2ef1018
to
ebfaff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this does not work.
Sadly our container builds from GitHub Actions are triggered only on main branch. Therefore no container CI action was triggered by this pull request. Therefore I pushed this branch into my own fork's main branch, and this resulted build failure https://github.com/tvainika/karapace/actions/runs/4675463034
I think build failure is because Gather context
step does not have all tags with fetched history. Actions/checkout needs fetch-depth
flag to fetch all tags.
Perhaps I should start in this end, building an image for PRs and adding some very basic smoke test. That would probably make it easier to gain confidence for a PR like this one later on. Very good idea that you tried this out on a fork! 🙏 The failure is a bit odd though, the I'll put this PR in draft for now, and will try to come back to it once we have smoke tests 🙂 |
9cc3247
to
4d7084c
Compare
With this commit we start building multi-arch container images to enable running containers on ARM systems. Delete outdated build and publish scripts under container/.
4d7084c
to
4d2c0d9
Compare
@tvainika I managed to get the build working on my fork now, I did these things:
Passing build: https://github.com/aiven-anton/karapace/actions/runs/4872183301/jobs/8690049653 |
About this change - What it does
With this commit we start building multi-arch container images to enable running containers on ARM systems.
Closes #521.
References #585.
Why this way
I did experimentation/debugging in this repository: https://github.com/aiven-anton/test-build-arm, see results of build 12 and 13.
Using the Docker actions makes for very low amount of boilerplate code for building containers.