Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: more stronger unique RPC subject names #1386

Closed
Lancetnik opened this issue Apr 19, 2024 · 0 comments · Fixed by #1484
Closed

Feature: more stronger unique RPC subject names #1386

Lancetnik opened this issue Apr 19, 2024 · 0 comments · Fixed by #1484
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request good first issue Good for newcomers

Comments

@Lancetnik
Copy link
Member

We should use smth more stronger, than just str(uuid4()) to generate unique reply-to topic for RPC requests in Redis (and other future brokers): https://github.com/airtai/faststream/blob/main/faststream/redis/publisher/producer.py#L71

I suggest to copy nats.NUID class to FastStream and use it like in the NatsBroker do: https://github.com/nats-io/nats.py/blob/main/nats/nuid.py
@Lancetnik Lancetnik added enhancement New feature or request good first issue Good for newcomers labels Apr 19, 2024
@Lancetnik Lancetnik added the Core Issues related to core FastStream functionality and affects to all brokers label May 16, 2024
@aKardasz aKardasz mentioned this issue May 29, 2024
Merged
8 tasks
@Lancetnik Lancetnik mentioned this issue Jun 9, 2024
Open
63 tasks
@Lancetnik Lancetnik moved this to Todo in FastStream Jun 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in FastStream Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request good first issue Good for newcomers
Projects
FastStream
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve Issue 1386, Add rpc_prefix aKardasz/faststream
1 participant
@Lancetnik