Automate publishing releases on GitHub #249
Conversation
ghost
self-requested a review
ghost
self-assigned this
.gitignore
Outdated
| # Vi | ||
| .swp |
There was a problem hiding this comment.
Isn't this file generated anyway? I bet they support vim too.
There was a problem hiding this comment.
Alternatively, does it make sense to commit this at all? Would we accept a PR for emacs support in our gitignore?
Maybe this is something users should configure locally, like so? https://stackoverflow.com/a/5724476
There was a problem hiding this comment.
Since its mostly me working on this code I quickly setup the gitignore to fit my working environment. User level global gitignores would be a good way of solving this as well. Probably superior even. 👍
If someone regularly commits to the project and wants an emacs gitignore I'd be happy to accept a PR. 😅
fastlane/Fastfile
Outdated
| version = get_version_number(target: "JOSESwift") | ||
|
|
||
| changelog = File.read("../CHANGELOG.md") | ||
| changes = changelog[/(- .+\(#.+\)\n)+/] |
There was a problem hiding this comment.
What is this regex doing? I get you're stripping chars, but why exactly?
There was a problem hiding this comment.
Filtering out the latest change set.
Blablabla
[1.2.0]
- Do Something (#123)
- Do Something else (#100)
[1.1.0]
- Start something (#99)
Will become:
- Do Something (#123)
- Do Something else (#100)
Which is the change log for the latest version that we want attached to the release.
There was a problem hiding this comment.
Might be worth dropping a source comment
There was a problem hiding this comment.
Yeah you're right. 👍 Will add this later!
ghost
self-requested a review
ghost
self-requested a review
|
@nathan-mohemian Updated .gitignore and Fastfile. 👌 |
|
Kudos, SonarCloud Quality Gate passed!
|
This will automatically publish a release including the latest changelog on GitHub when the
releaselane is run.The latest release (2.3.1) was created using this lane.
Running the whole
releaselane on CI whenever a prepare pr is merged would be the next step in automating the release process.