From 09482d7b1a049bebfec94e7709a301b97addbad2 Mon Sep 17 00:00:00 2001 From: Mathieu De Coster Date: Mon, 5 Feb 2024 17:03:24 +0100 Subject: [PATCH] Revert Python to version 3.10 #121 (#123) * Revert Python to version 3.10 #121 * Keep 3.11 in the testing matrix --- CHANGELOG.md | 3 ++- README.md | 2 -- environment.yaml | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index afea6cd..634070d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,7 +25,8 @@ This project uses a [CalVer](https://calver.org/) versioning scheme with monthly ### Changed -- dropped support for python 3.8 and added 3.11 to the testing matrix [#103](https://github.com/airo-ugent/airo-mono/issues/103) +- Dropped support for python 3.8 and added 3.11 to the testing matrix [#103](https://github.com/airo-ugent/airo-mono/issues/103). +- Set python version to 3.10 because of an issue with the `ur_rtde` wheels [#121](https://github.com/airo-ugent/airo-mono/issues/121). Updated README.md to reflect this change. ### Fixed - Fixed bug in `get_colored_point_cloud()` that removed some points see issue #25. diff --git a/README.md b/README.md index ad2a52f..ed75a90 100644 --- a/README.md +++ b/README.md @@ -112,8 +112,6 @@ we use github actions to do the following checks on each PR, push to master (and The tests are executed for each package in isolation using [github actions Matrices](https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs), which means that only that package and its dependencies are installed in an environment to make sure each package correctly declares its dependencies. The downside is that this has some overhead in creating the environments, so we should probably look into caching them once the runtime becomes longer. -We test on python 3.8 (default on ubuntu 20.04), 3.9 and 3.10 (default on Ubuntu 22.04). It is important to test these versions explicitly, e.g. typing with `list` instead of `typing.List` is not allowed in 3.8, but it is in >=3.9. - ### Management of (local) dependencies An issue with using a monorepo is that you want to have packages declare their local dependencies as well. But before you publish your packages or if you want to test unreleased code (as usually), this creates an issue: where should pip find these local package? Though there exist more advanced package managers such as Poetry, ([more background on package and dependency management in python](https://ealizadeh.com/blog/guide-to-python-env-pkg-dependency-using-conda-poetry/) diff --git a/environment.yaml b/environment.yaml index 3f9104e..b4665ee 100644 --- a/environment.yaml +++ b/environment.yaml @@ -2,7 +2,7 @@ name: airo-mono channels: - conda-forge dependencies: - - python=3.11 + - python=3.10 - pip - pip: - -e airo-typing/