Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Oracle specify schema(s) to discover. #5779

Merged
merged 5 commits into from
Sep 2, 2021

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Sep 1, 2021

What

Closes #4944 .

How

Add a field to the spec, and modify connector logic to only look at the given configured schemas.

The alternative is moving from JDBC to raw SQL, which is messy and complicated.

Recommended reading order

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 1, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 1, 2021
@davinchia
Copy link
Contributor Author

davinchia commented Sep 1, 2021

/test connector=source-oracle

🕑 source-oracle https://github.com/airbytehq/airbyte/actions/runs/1189025432
❌ source-oracle https://github.com/airbytehq/airbyte/actions/runs/1189025432

@jrhizor jrhizor temporarily deployed to more-secrets September 1, 2021 06:16 Inactive
@davinchia
Copy link
Contributor Author

davinchia commented Sep 1, 2021

/test connector=source-oracle

🕑 source-oracle https://github.com/airbytehq/airbyte/actions/runs/1189459303
✅ source-oracle https://github.com/airbytehq/airbyte/actions/runs/1189459303

@jrhizor jrhizor temporarily deployed to more-secrets September 1, 2021 08:48 Inactive
@davinchia
Copy link
Contributor Author

davinchia commented Sep 2, 2021

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1193786437
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1193786437

@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 10:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 10:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 10:24 Inactive
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @davinchia

@AlexandruManolache1
Copy link

hi @davinchia , @marcosmarxm seems that somehow this is not working any more in 0.32
i opened #8085 regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
4 participants