Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Oracle: use airbyte default column name + correct ci tests #5746

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Aug 30, 2021

What

2 things:

  1. Use "_AIRBYTE_DATA" as column name in oracle destination. This will help us improving integrating Oracle in normalization module.

  2. After Destination Oracle: change table limit and format record data #5542 we started using Oracle AWS instance to run integration tests. The test/publish works when developing the PR but after that CI started failing consecutively. Reason: is because the function tearDown wasn't removing tables/data after each test. The problem occurs when the test testLineBreakCharacters ran before testIncrementalSync the record inserted from first test was counted in the second one.

OracleIntegrationTest > testIncrementalSync() FAILED
    org.opentest4j.AssertionFailedError: expected: <6> but was: <7>

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@marcosmarxm marcosmarxm requested a review from cgardens August 30, 2021 23:42
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 30, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 30, 2021

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1184152876
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1184152876

@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 23:53 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 30, 2021
Comment on lines 167 to -168
var tables = getAllTables(database);
tables.removeAll(allTables);
Copy link
Member Author

@marcosmarxm marcosmarxm Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is strange. We get all tables and remove all of them. The variable tables was empty at the end and we didn't remove data/tables in tearDown. The function getAllTables(database) get all tables where the user is the owner.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 31, 2021

/publish connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1184342731
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1184342731

@jrhizor jrhizor temporarily deployed to more-secrets August 31, 2021 01:12 Inactive
@marcosmarxm marcosmarxm merged commit 5a0d7af into master Aug 31, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/oracle-dest-column-name branch August 31, 2021 12:27
@marcosmarxm marcosmarxm mentioned this pull request Aug 31, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants