Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish source bigcommerce #5722

Merged
merged 4 commits into from
Aug 28, 2021
Merged

Publish source bigcommerce #5722

merged 4 commits into from
Aug 28, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Aug 28, 2021 •
edited
Loading

What

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 28, 2021
@tuliren tuliren requested a review from marcosmarxm August 28, 2021 21:59
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 28, 2021
@tuliren
Copy link
Contributor Author

tuliren commented Aug 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-bigcommerce

🕑 connectors/source-bigcommerce https://github.com/airbytehq/airbyte/actions/runs/1177998445
✅ connectors/source-bigcommerce https://github.com/airbytehq/airbyte/actions/runs/1177998445

@jrhizor jrhizor temporarily deployed to more-secrets August 28, 2021 22:02 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Aug 28, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-bigcommerce

🕑 connectors/source-bigcommerce https://github.com/airbytehq/airbyte/actions/runs/1178014055
✅ connectors/source-bigcommerce https://github.com/airbytehq/airbyte/actions/runs/1178014055

@jrhizor jrhizor temporarily deployed to more-secrets August 28, 2021 22:10 Inactive
@tuliren tuliren merged commit 073a1d5 into master Aug 28, 2021
@tuliren tuliren deleted the liren/publish-source-bigcommerce branch August 28, 2021 22:22
@jrhizor jrhizor mentioned this pull request Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bigcommerce connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliren @jrhizor @ycherniaiev