Validate links in frontend in CI #13600
Conversation
github-actions
bot
added
area/platform
package-lock.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this file add intended?
There was a problem hiding this comment.
Absolutely not... I accidentally executed npm i inside the root directory and apparently missed this. Will remove.
| @@ -1,7 +1,7 @@ | |||
| import { SegmentAnalytics } from "core/analytics/types"; | |||
| import { Feature } from "hooks/services/Feature"; | |||
|
|
|||
| import { UiConfig } from "./uiConfig"; | |||
| import { OutboundLinks } from "./links"; | |||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 14 * * *' |
There was a problem hiding this comment.
So not necessarily tied to a merge but just periodically check?
There was a problem hiding this comment.
This workflow will just periodically check, but I also added it to the build, via the gradle build file inside the airbyte-webapp folder, so that any assemble/build of the gradle project will check it as well. Thus it would be part of our regular Frontend: Build runs. Since some breakage we've seen in the past though came from changes in the docs, I wanted an additional scheduled check.
What
Closes #12694
This PR adds automated validation for all links used in the frontend. We should make sure they are all part of the
links.tsfile (I renamed this fromuiConfig.ts.This check will run as part of the regular CI build run now. Also in addition there is a scheduled daily check that will post notifications to
#dev-frontendif the run fails.This also changes the variable name from
config.ui.<link name>to the more meaningfulconfig.links.