Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot: add date-type to fields in all schemas #5688

Closed
marcosmarxm opened this issue Aug 26, 2021 · 1 comment · Fixed by #10492
Closed

Source Hubspot: add date-type to fields in all schemas #5688

marcosmarxm opened this issue Aug 26, 2021 · 1 comment · Fixed by #10492

Comments

@marcosmarxm
Copy link
Member

Tell us about the problem you're trying to solve

PR #5685 removed all date-time format from streams.
PR #5661 adds tests in sources to validate the json format and will help adding this to schemas.

Describe the solution you’d like

All fields in streams should be format correctly in normalization.

Describe the alternative you’ve considered or used

None

Additional context

Add any other context or screenshots about the feature request here.

Are you willing to submit a PR?

Remove this with your answer :-)

@bazarnov
Copy link
Collaborator

bazarnov commented Sep 3, 2021

@marcosmarxm you forgot to to add the correct PR in changelog of Hubspot connector during this update. https://docs.airbyte.io/integrations/sources/hubspot#overview
It says: 0.1.11 = PR of 5463, but must be yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants