From dc1002819dc12de53c85fbece895b5f55f96b1f8 Mon Sep 17 00:00:00 2001 From: cgardens Date: Mon, 24 May 2021 16:56:48 -0700 Subject: [PATCH] code review feedback --- .../src/main/java/io/airbyte/commons/util/MoreLists.java | 2 +- .../test/java/io/airbyte/commons/util/MoreListsTest.java | 2 +- .../standardtest/destination/TestDestination.java | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/airbyte-commons/src/main/java/io/airbyte/commons/util/MoreLists.java b/airbyte-commons/src/main/java/io/airbyte/commons/util/MoreLists.java index 2ae5b3e7a66a9..b02929d62556d 100644 --- a/airbyte-commons/src/main/java/io/airbyte/commons/util/MoreLists.java +++ b/airbyte-commons/src/main/java/io/airbyte/commons/util/MoreLists.java @@ -49,7 +49,7 @@ public static Optional last(List list) { * @param type * @return new list with elements of original reversed. */ - public static List reverse(List list) { + public static List reversed(List list) { final ArrayList reversed = new ArrayList<>(list); Collections.reverse(reversed); return reversed; diff --git a/airbyte-commons/src/test/java/io/airbyte/commons/util/MoreListsTest.java b/airbyte-commons/src/test/java/io/airbyte/commons/util/MoreListsTest.java index 71fc805d98b70..96d5c52bb4ad9 100644 --- a/airbyte-commons/src/test/java/io/airbyte/commons/util/MoreListsTest.java +++ b/airbyte-commons/src/test/java/io/airbyte/commons/util/MoreListsTest.java @@ -49,7 +49,7 @@ void testLast() { @Test void testReverse() { final ArrayList originalList = Lists.newArrayList(1, 2, 3); - assertEquals(List.of(3, 2, 1), MoreLists.reverse(originalList)); + assertEquals(List.of(3, 2, 1), MoreLists.reversed(originalList)); assertEquals(List.of(1, 2, 3), originalList); } diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/TestDestination.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/TestDestination.java index 0238a4185ef3e..5c9098cef7b8d 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/TestDestination.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/TestDestination.java @@ -820,16 +820,16 @@ private StandardCheckConnectionOutput runCheck(JsonNode config) throws WorkerExc private void runSyncAndVerifyStateOutput(JsonNode config, List messages, ConfiguredAirbyteCatalog catalog) throws Exception { final List destinationOutput = runSync(config, messages, catalog); - final AirbyteMessage expectedStateMessage = MoreLists.reverse(messages) + final AirbyteMessage expectedStateMessage = MoreLists.reversed(messages) .stream() .filter(m -> m.getType() == Type.STATE) - .findAny() + .findFirst() .orElseThrow(() -> new IllegalArgumentException("All message sets used for testing should include a state record")); - final AirbyteMessage actualStateMessage = MoreLists.reverse(destinationOutput) + final AirbyteMessage actualStateMessage = MoreLists.reversed(destinationOutput) .stream() .filter(m -> m.getType() == Type.STATE) - .findAny() + .findFirst() .orElseGet(() -> { fail("Destination failed to output state"); return null;