Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AxisLeft: hideZero breaks ticks formatting #815

Closed
vfabioux opened this issue Sep 28, 2020 · 1 comment · Fixed by #818
Closed

AxisLeft: hideZero breaks ticks formatting #815

vfabioux opened this issue Sep 28, 2020 · 1 comment · Fixed by #818
Labels

Comments

@vfabioux
Copy link

Hi,

There is a small bug caused by v0.0.199 (I can confirm it worked with v0.0.198 in my project), but I'm not sure how to fix it.

Setting hideZero to true on an AxisLeft makes the last tick ignore tickLabelProps.

Example:
https://codesandbox.io/s/heuristic-germain-5ywnv?file=/Example.tsx
Here the "90" tick is not formatted correctly.
This bug happens only when a 0 should be shown but hideZero is used to hide it.
If you remove hideZero (line 59) it will work again.
Same if you set temperatureScale domain's minimum to 10 (line 29) and keep hideZero.

@williaster
Copy link
Collaborator

Thanks for the report @vfabioux, I'll work on a fix for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants