Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] add GridRadial and GridPolar #405

Closed
wants to merge 15 commits into from

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

  • This PR adds <GridRadial /> and <GridPolar /> components to @vx/grid, and updates the RadialLine demo to be implemented using them.

image

🐛 Bug Fix

  • Also fixes a bug in the @vx/shape/Arc component where passing any prop (e.g., innerRadius) as 0 has no effect because of the if/else logic. This is needed for the implementation of <GridRadial /> because in order to use d3's arc() function without data, you must fully specify inner/outerRadius and start/endAngle, so I included it in this PR.

Will push the doc changes later tonight.

@williaster
Copy link
Collaborator Author

to clarify what the grid on its own looks like

image

@hshoff
Copy link
Member

hshoff commented Jan 8, 2019

Thought about this more, how about we rename <GridPolar/> to <GridAngle />?

Then we could make a <GridPolar /> which uses both <GridAngle /> and <GridRadial /> (like the cartesian coordinate counterpart <Grid /> which uses <GridRows /> and <GridColumns />).

@williaster
Copy link
Collaborator Author

I dig it, will update 👍

@hshoff hshoff added this to the v0.0.184 milestone Jan 8, 2019
@hshoff hshoff modified the milestones: v0.0.184, v0.0.185, v0.0.186 Jan 28, 2019
@hshoff hshoff removed this from the v0.0.186 milestone Feb 28, 2019
@williaster
Copy link
Collaborator Author

closed in favor of #1007

@williaster williaster closed this Jan 15, 2021
@williaster williaster deleted the chris--radial-grids branch January 15, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants