-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] add GridRadial
and GridPolar
#405
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thought about this more, how about we rename Then we could make a |
I dig it, will update 👍 |
williaster
force-pushed
the
chris--radial-grids
branch
from
March 18, 2019 17:08
1642aaa
to
e20bc5e
Compare
williaster
force-pushed
the
chris--radial-grids
branch
from
July 16, 2019 19:25
fdb2b65
to
cc09760
Compare
closed in favor of #1007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
<GridRadial />
and<GridPolar />
components to@vx/grid
, and updates theRadialLine
demo to be implemented using them.🐛 Bug Fix
@vx/shape/Arc
component where passing any prop (e.g.,innerRadius
) as0
has no effect because of theif/else
logic. This is needed for the implementation of<GridRadial />
because in order to used3
'sarc()
function without data, you must fully specifyinner/outerRadius
andstart/endAngle
, so I included it in this PR.Will push the doc changes later tonight.