Fixes filters emitted from table viz (#2335)

apache · Mar 6, 2017 · ad4a950 · ad4a950
1 parent bd480e0
commit ad4a950
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/superset/assets/javascripts/explorev2/components/ChartContainer.jsx b/superset/assets/javascripts/explorev2/components/ChartContainer.jsx
@@ -110,6 +110,10 @@ class ChartContainer extends React.PureComponent {
         {}
       ),
 
+      addFilter: () => {},
+
+      removeFilter: () => {},
+
       done: () => {},
       clearError: () => {
         // no need to do anything here since Alert is closable

diff --git a/superset/assets/visualizations/table.js b/superset/assets/visualizations/table.js
@@ -68,18 +68,24 @@ function tableVis(slice, payload) {
     .enter()
     .append('tr')
     .selectAll('td')
-    .data((row) => data.columns.map((c) => {
-      let val = row[c];
+    .data(row => data.columns.map(c => {
+      const val = row[c];
+      let html;
+      const isMetric = metrics.indexOf(c) >= 0;
       if (c === 'timestamp') {
-        val = timestampFormatter(val);
+        html = timestampFormatter(val);
       }
       if (typeof(val) === 'string') {
-        val = `<span class="like-pre">${val}</span>`;
+        html = `<span class="like-pre">${val}</span>`;
+      }
+      if (isMetric) {
+        html = slice.d3format(c, val);
       }
       return {
         col: c,
         val,
-        isMetric: metrics.indexOf(c) >= 0,
+        html,
+        isMetric,
       };
     }))
     .enter()
@@ -118,12 +124,7 @@ function tableVis(slice, payload) {
     .style('cursor', function (d) {
       return (!d.isMetric) ? 'pointer' : '';
     })
-    .html((d) => {
-      if (d.isMetric) {
-        return slice.d3format(d.col, d.val);
-      }
-      return d.val;
-    });
+    .html(d => d.html ? d.html : d.val);
   const height = slice.height();
   let paging = false;
   let pageLength;