Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RxJava3? #352

Open
Dugin123 opened this issue Feb 20, 2020 · 8 comments
Open

Add support for RxJava3? #352

Dugin123 opened this issue Feb 20, 2020 · 8 comments

Comments

@Dugin123
Copy link

is any plan to support RxJava3?

@gpeal
Copy link
Collaborator

gpeal commented Feb 20, 2020

@BenSchwab @elihart This might be a good opportunity to the coroutines defualt + rxjava2 and rxjava3 extension libraries. What do you think?

@gpeal gpeal changed the title is any plan to support RxJava3? Add support for RxJava3? Feb 20, 2020
@Dugin123
Copy link
Author

I prefer RxJava than coroutines. I think RxJava is more powerful and fitable functional programming.
what do you think below structure?
core+rxjava3
core+rxjava2
core+coroutines?

Anyway, regardless of module structure, RxJava3 has released official ver, so I hope it will be support.

@elihart
Copy link
Contributor

elihart commented Feb 24, 2020

Yes, I think this would tie in nicely to split extension libraries for these options. I would think that an extension library for rxjava3 would be pretty simple once we have one for rxjava2.

@jpventura
Copy link
Contributor

@Dugin123 RxJava 2.x officially is at maintenance mode.

Thus we could piggyback coroutines refactor to simply offer 3.x built over extensions when JetBrains officially support it (see #347).

@Dugin123
Copy link
Author

@jpventura
Now JetBrains support kotlinx-coroutines-rx3.

@renaudcerrato
Copy link

RxJava2 is in maintenance mode and support will stop on March 1st 2021 (source). Migrating is easy, will you accept a PR ?

@elihart
Copy link
Contributor

elihart commented Sep 8, 2020

Yes, if you look at the 2.0 release branch (https://github.com/airbnb/MvRx/tree/release/2.0.0) there is a mvrx-rxjava2 module. I think we would be open to a PR that adds an equivalent module for rxjava3. I imagine it would be pretty straightforward to mirror what is done in the rxjava2 module

@JagadeeshBabuDamarasingu

hi @gpeal @elihart , I have opened a new PR #685 for this issue, please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants