From de8156d9469dfd67de97353c71495d49cdca439d Mon Sep 17 00:00:00 2001 From: Miguel Jimenez Date: Wed, 8 Nov 2023 16:44:09 -0500 Subject: [PATCH 1/2] Revert Epoxy Hosting View layout margin changes --- Sources/EpoxyCore/SwiftUI/EpoxySwiftUIHostingView.swift | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Sources/EpoxyCore/SwiftUI/EpoxySwiftUIHostingView.swift b/Sources/EpoxyCore/SwiftUI/EpoxySwiftUIHostingView.swift index e510385..b2ce33a 100644 --- a/Sources/EpoxyCore/SwiftUI/EpoxySwiftUIHostingView.swift +++ b/Sources/EpoxyCore/SwiftUI/EpoxySwiftUIHostingView.swift @@ -87,7 +87,6 @@ public final class EpoxySwiftUIHostingView: UIView, EpoxyableVie } }) layoutMargins = .zero - insetsLayoutMarginsFromSafeArea = false } @available(*, unavailable) @@ -346,11 +345,11 @@ public final class EpoxySwiftUIHostingView: UIView, EpoxyableVie viewController.view.leadingAnchor.constraint(equalTo: leadingAnchor), // Pining the hosting view controller to layoutMarginsGuide ensures the content respects the top safe area // when installed inside a `TopBarContainer` - viewController.view.topAnchor.constraint(equalTo: layoutMarginsGuide.topAnchor), + viewController.view.topAnchor.constraint(equalTo: topAnchor), viewController.view.trailingAnchor.constraint(equalTo: trailingAnchor), // Pining the hosting view controller to layoutMarginsGuide ensures the content respects the bottom safe area // when installed inside a `BottomBarContainer` - viewController.view.bottomAnchor.constraint(equalTo: layoutMarginsGuide.bottomAnchor), + viewController.view.bottomAnchor.constraint(equalTo: bottomAnchor), ]) viewController.didMove(toParent: parent) From 51e683377f6d90eda9fe5876742312d6c94a4320 Mon Sep 17 00:00:00 2001 From: Miguel Jimenez Date: Wed, 8 Nov 2023 16:44:32 -0500 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fbfb15c..3a459bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,8 +21,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 approach to resolve an issue that could cause collection view cells to layout with unexpected dimensions - Made new layout-based SwiftUI cell rendering option the default. -- Pin `EpoxySwiftUIHostingView` content to `layoutMarginsGuide` to ensure content respects the safe area - when installed in a `TopBarContainer` or `BottomBarContainer`. ## [0.10.0](https://github.com/airbnb/epoxy-ios/compare/0.9.0...0.10.0) - 2023-06-29