Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to use the prop-types package #890 #894

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Update docs to use the prop-types package #890 #894

merged 1 commit into from
Apr 13, 2017

Conversation

hisk
Copy link
Contributor

@hisk hisk commented Apr 13, 2017

Not sure if I should also include explicit imports in the setContext examples.

ljharb
ljharb reviewed Apr 13, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explicit imports would be better.

@ljharb ljharb added the docs label Apr 13, 2017
ljharb
ljharb approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 419478d into enzymejs:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hisk @ljharb