Breaking: lifecycleExperimental by default #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Sep 26, 2017
|
I'm working on rebasing and fixing a test. |
lelandrichardson
force-pushed
the
lifecycle-experimental-as-default
branch
from
e8296d7 to
9930f3e
Compare
lelandrichardson
force-pushed
the
lifecycle-experimental-as-default
branch
from
89f3322 to
bb4c6b6
Compare
|
Thanks! |
ljharb
reviewed
Sep 26, 2017
| constructor(nodes, root, options = {}) { | ||
| validateOptions(options); | ||
| constructor(nodes, root, passedOptions = {}) { | ||
| validateOptions(passedOptions); |
There was a problem hiding this comment.
How come ReactWrapper doesn't validate its options?
vzvu3k6k
added a commit
to vzvu3k6k/gitify
that referenced
this pull request
Oct 21, 2018
enzyme calls componentDidMount() by default as of v3. * https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md#breaking-changes * enzymejs/enzyme#1140
vzvu3k6k
added a commit
to vzvu3k6k/gitify
that referenced
this pull request
Oct 21, 2018
enzyme calls componentDidMount() by default as of v3. * https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md#breaking-changes * enzymejs/enzyme#1140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a discussion in #678 about this.
If enzyme chooses this option, the time has come.
I think this PR needs more works, which are tests and documentation.
Does enzyme enable lifecyleExperimental by default at v3?