[*] [dev deps] update eslint-plugin-react, eslint-plugin-import

enzymejs · May 5, 2019 · 464c6cb · 464c6cb
1 parent a9bff0b
commit 464c6cb
Show file tree

Hide file tree

Showing 15 changed files with 54 additions and 68 deletions.
diff --git a/package.json b/package.json
@@ -71,10 +71,10 @@
     "coveralls": "^2.13.3",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
     "eslint-plugin-markdown": "^1.0.0",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "gitbook-cli": "^1.0.1",
     "gitbook-plugin-anchors": "^0.7.1",
     "gitbook-plugin-codeblock-disable-glossary": "0.0.1",

diff --git a/packages/enzyme-adapter-react-13/package.json b/packages/enzyme-adapter-react-13/package.json
@@ -51,9 +51,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-14/package.json b/packages/enzyme-adapter-react-14/package.json
@@ -54,9 +54,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-15.4/package.json b/packages/enzyme-adapter-react-15.4/package.json
@@ -55,9 +55,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-15/package.json b/packages/enzyme-adapter-react-15/package.json
@@ -54,9 +54,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-16.1/package.json b/packages/enzyme-adapter-react-16.1/package.json
@@ -54,9 +54,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-16.2/package.json b/packages/enzyme-adapter-react-16.2/package.json
@@ -55,9 +55,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-16.3/package.json b/packages/enzyme-adapter-react-16.3/package.json
@@ -55,9 +55,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-16/package.json b/packages/enzyme-adapter-react-16/package.json
@@ -55,9 +55,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-react-helper/package.json b/packages/enzyme-adapter-react-helper/package.json
@@ -45,9 +45,9 @@
     "enzyme": "^3.0.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "react": "0.13.x || 0.14.x || ^15.0.0-0 || ^16.0.0-0 || ^16.3.0-0 || ^16.4.0-0",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-adapter-utils/package.json b/packages/enzyme-adapter-utils/package.json
@@ -51,9 +51,9 @@
     "babel-preset-airbnb": "^2.6.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "rimraf": "^2.6.3",
     "safe-publish-latest": "^1.1.2"

diff --git a/packages/enzyme-example-mocha/package.json b/packages/enzyme-example-mocha/package.json
@@ -22,9 +22,9 @@
     "babel-register": "^6.26.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "jsdom": "^11.5.1",
     "mocha": "^3.5.3",

diff --git a/packages/enzyme-test-suite/package.json b/packages/enzyme-test-suite/package.json
@@ -53,9 +53,9 @@
   "devDependencies": {
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
     "eslint-plugin-mocha": "^5.3.0",
-    "eslint-plugin-react": "^7.12.4"
+    "eslint-plugin-react": "^7.13.0"
   }
 }
diff --git a/packages/enzyme-test-suite/test/Adapter-spec.jsx b/packages/enzyme-test-suite/test/Adapter-spec.jsx
@@ -57,6 +57,12 @@ function cleanNode(node) {
 }
 
 describe('Adapter', () => {
+  class RendersNull extends React.Component {
+    render() {
+      return null;
+    }
+  }
+
   describe('error message', () => {
     afterEach(() => {
       configure({ adapter });
@@ -143,12 +149,17 @@ describe('Adapter', () => {
       expect(prettyFormat(nodeA)).to.equal(prettyFormat(nodeB));
     }
 
-    /* eslint react/destructuring-assignment: 0 */
     class BamBam extends React.Component {
-      render() { return (<div>{this.props.children}</div>); }
+      render() {
+        const { children } = this.props;
+        return (<div>{children}</div>);
+      }
     }
     class FooBar extends React.Component {
-      render() { return (<BamBam>{this.props.children}</BamBam>); }
+      render() {
+        const { children } = this.props;
+        return (<BamBam>{children}</BamBam>);
+      }
     }
     class One extends React.Component {
       render() { return (<FooBar><span><FooBar /></span></FooBar>); }
@@ -180,9 +191,7 @@ describe('Adapter', () => {
     it('treats mixed children correctly', () => {
       class Foo extends React.Component {
         render() {
-          return (
-            <div>hello{4}{'world'}</div>
-          );
+          return (<div>hello{4}{'world'}</div>);
         }
       }
 
@@ -219,24 +228,18 @@ describe('Adapter', () => {
     });
 
     it('treats null renders correctly', () => {
-      class Foo extends React.Component {
-        render() {
-          return null;
-        }
-      }
-
       const options = { mode: 'mount' };
       const renderer = adapter.createRenderer(options);
 
-      renderer.render(<Foo />);
+      renderer.render(<RendersNull />);
 
       const node = renderer.getNode();
 
       cleanNode(node);
 
       expect(prettyFormat(node)).to.equal(prettyFormat({
         nodeType: 'class',
-        type: Foo,
+        type: RendersNull,
         props: {},
         key: undefined,
         ref: null,
@@ -417,23 +420,17 @@ describe('Adapter', () => {
       const options = { mode: 'mount' };
       const renderer = adapter.createRenderer(options);
 
-      class Foo extends React.Component {
-        render() {
-          return null;
-        }
-      }
-
-      renderer.render(<Foo />);
+      renderer.render(<RendersNull />);
 
       const node = renderer.getNode();
 
-      expect(node.instance).to.be.instanceof(Foo);
+      expect(node.instance).to.be.instanceof(RendersNull);
 
       cleanNode(node);
 
       expect(prettyFormat(node)).to.equal(prettyFormat({
         nodeType: 'class',
-        type: Foo,
+        type: RendersNull,
         props: {},
         key: undefined,
         ref: null,
@@ -675,12 +672,6 @@ describe('Adapter', () => {
   });
 
   it('render node with updated props', () => {
-    class Dummy extends React.Component {
-      render() {
-        return null;
-      }
-    }
-
     class Counter extends React.Component {
       constructor(props) {
         super(props);
@@ -692,7 +683,7 @@ describe('Adapter', () => {
       }
 
       render() {
-        return <Dummy {...this.state} />;
+        return <RendersNull {...this.state} />;
       }
     }
 
@@ -712,21 +703,19 @@ describe('Adapter', () => {
   });
 
   it('renders basic shallow as well', () => {
-    // eslint-disable-next-line react/require-render-return
     class Bar extends React.Component {
       constructor(props) {
         super(props);
         throw new Error('Bar constructor should not be called');
       }
 
-      render() {
+      render() { // eslint-disable-line react/require-render-return
         throw new Error('Bar render method should not be called');
       }
     }
 
-    // eslint-disable-next-line react/require-render-return
     class Foo extends React.Component {
-      render() {
+      render() { // eslint-disable-line react/require-render-return
         throw new Error('Foo render method should not be called');
       }
     }
@@ -801,14 +790,13 @@ describe('Adapter', () => {
   });
 
   it('does not erroneously add a key when refs are present', () => {
-    // eslint-disable-next-line react/require-render-return
     class Inner extends React.Component {
       constructor(props) {
         super(props);
         throw new Error('Inner constructor should not be called');
       }
 
-      render() {
+      render() { // eslint-disable-line react/require-render-return
         throw new Error('Inner render method should not be called');
       }
     }
@@ -857,14 +845,13 @@ describe('Adapter', () => {
   });
 
   it('adds keys correctly to elements that have them', () => {
-    // eslint-disable-next-line react/require-render-return
     class Inner extends React.Component {
       constructor(props) {
         super(props);
         throw new Error('Inner constructor should not be called');
       }
 
-      render() {
+      render() { // eslint-disable-line react/require-render-return
         throw new Error('Inner render method should not be called');
       }
     }
@@ -904,14 +891,13 @@ describe('Adapter', () => {
   });
 
   it('adds null keys to elements correctly', () => {
-    // eslint-disable-next-line react/require-render-return
     class Inner extends React.Component {
       constructor(props) {
         super(props);
         throw new Error('Inner constructor should not be called');
       }
 
-      render() {
+      render() { // eslint-disable-line react/require-render-return
         throw new Error('Inner render method should not be called');
       }
     }

diff --git a/packages/enzyme/package.json b/packages/enzyme/package.json
@@ -63,9 +63,9 @@
     "babel-preset-airbnb": "^2.6.0",
     "eslint": "^5.16.0",
     "eslint-config-airbnb": "^17.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-jsx-a11y": "^6.2.1",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.13.0",
     "in-publish": "^2.0.0",
     "jsdom": "^6.5.1",
     "rimraf": "^2.6.3",