adjusting date formats #86
Merged
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's nice, much more verbose. A bit redundant in places but overall much better! |
mistercrunch
added a commit
that referenced
this pull request
Dec 16, 2015
…ate_formats adjusting date formats
|
yea, if we want to trim it down at some point, we def should, but this way there shouldn't be any ambiguity about what you're looking at |
hughhhh
referenced
this pull request
in lyft/incubator-superset
Apr 1, 2018
Author: none lyft/ops_DEPRECATED@81d0d70...7d48269 NOT PASSING TESTS
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 14, 2018
…Fixes Cherrypick a few dash fixes
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
…cy (apache#86) * feat: add new subgenerators for legacy package and demo * feat: make the default generator provide choices to choose subgenerators
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
…cy (#86) * feat: add new subgenerators for legacy package and demo * feat: make the default generator provide choices to choose subgenerators
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
…cy (#86) * feat: add new subgenerators for legacy package and demo * feat: make the default generator provide choices to choose subgenerators
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
…cy (#86) * feat: add new subgenerators for legacy package and demo * feat: make the default generator provide choices to choose subgenerators
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
…cy (#86) * feat: add new subgenerators for legacy package and demo * feat: make the default generator provide choices to choose subgenerators
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @michellethomas @mistercrunch
Hey guys,
I made some updates to the date formats that I think make them much more useful. The basic problem I was trying to solve is just adding more context to the charts about what you were looking at. Sometimes, the day of week was shown, or just the month and it was unclear what you were looking at. I tried to keep it clean like it was, but also add more context. The goal is to make it less likely to make a mistake when people are passing around screen shots.
I did another small fix where I made the y-axis format on the context chart the same as on the main y-axis.
For adjusting the dates, I just changed the rules and then also added margin on the right to accommodate the longer dates, added a staggered effect to prevent overlapping, and took away a little height to make everything fit.
I tested it with my own dataset which I decided to not include as a default. It isn't all that interesting.
LMK if you have any questions and here are some pre/post screen shots.