Null sourceObserver in MvRxLifecyclewareObserver onDestroy to fix leak #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
hellohuanlin
approved these changes
Oct 4, 2018
| private val activeState: Lifecycle.State = DEFAULT_ACTIVE_STATE, | ||
| private val alwaysDeliverLastValueWhenUnlocked: Boolean = false, | ||
| private val sourceObserver: Observer<T>) : AtomicReference<Disposable>(), LifecycleObserver, Observer<T>, Disposable { | ||
| owner: LifecycleOwner, |
There was a problem hiding this comment.
can we make the owner a private var and optional?
There was a problem hiding this comment.
Oh thanks for pointing this out. We can make the constructor take non-null types, but make the main constructor take private, nullable types.
| if (!isDisposed) { | ||
| dispose() | ||
| } | ||
| owner = null | ||
| sourceObserver = null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a collection of disposables in a viewmodel which are disposed onClear:
However,
MvRxLifecycleAwareObservermaintains a reference to a source observer (often fragment). While we dispose that subscription inonDestroyof the fragment, theCompositeObservableinBaseMvRxViewModelretains a reference to it, leaking the fragment untilonClearis called for the ViewModel. If you rotate your phone a bunch, you will have many fragments referenced via this chain beforeonClearis called.