Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fragment reference for fragment view model lifecycle scope #110

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Use fragment reference for fragment view model lifecycle scope #110

merged 1 commit into from
Oct 3, 2018

Conversation

BenSchwab
Copy link
Collaborator

The lifecycle observer for any view model obtained by a fragment should be the fragment. Currently we are leaking fragments until their activity is destroyed.

elihart
elihart approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@elihart elihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! thanks

@BenSchwab BenSchwab merged commit 69f5c87 into master Oct 3, 2018
@BenSchwab BenSchwab mentioned this pull request Oct 3, 2018
Merged
@BenSchwab BenSchwab deleted the bschwab--fix-fragment-scope-leak branch December 19, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elihart elihart elihart approved these changes

@gpeal gpeal gpeal approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenSchwab @gpeal @elihart