Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor errors in custom runners #62

Open
aionick opened this issue Jun 12, 2019 · 0 comments
Open

Minor errors in custom runners #62

aionick opened this issue Jun 12, 2019 · 0 comments
Labels
low priority A lower priority issue

Comments

@aionick
Copy link
Contributor

aionick commented Jun 12, 2019

Currently, if you write a test with an annotation like @Test(expected = NullPointerException.class) your test will correctly succeed if a NPE is thrown, however, it will incorrectly succeed if no NPE is thrown.

It might also be worth having someone verify that the @BeforeClass @Before, @Test, @After @AfterClass logic is correct when exceptions are thrown in one or more of these stages. This is all being handled correctly when nothing goes wrong, but it might not be when something does go wrong.

Note: all of this is very low priority considering that no one is writing any tests expecting exceptions (that would be very questionable anyway since we are doing full-scale integration tests here...) and no tests are making use of before's and after's either.

@aionick aionick added the low priority A lower priority issue label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority A lower priority issue
Projects
None yet
Development

No branches or pull requests

1 participant