Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value transferred available immediately #34

Open
iamyulong opened this issue Nov 19, 2018 · 0 comments
Open

Make value transferred available immediately #34

iamyulong opened this issue Nov 19, 2018 · 0 comments

Comments

@iamyulong
Copy link
Contributor

iamyulong commented Nov 19, 2018

In the current FastVM implementation, the value being transferred through transaction are not available to the callee contract. This has caused a few trouble for the Rust kernel implementation, due to a transaction on the Mastery testnet. See https://mastery.aion.network/#/transaction/ff8b53df5b06ee1e6569e437d83766ec747b331e7f2e92e6f3c38bffdec0cc99

Double checked the Ethereum's implementation, it seems that different clients have different implementation:

  • Go-ethereum/Parity do the value transfer before the code execution
  • EthereumJ do the value transfer after the code execution

In Aion, the value transfer after the code execution for the transactions; before the code execution for the CALL or CREATE opcodes. For consistency, I'd prefer to change the behavior for transaction, by conducting value transfer before code execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant