Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrived example used #53

Open
fulldecent opened this issue Jun 22, 2019 · 4 comments
Open

Contrived example used #53

fulldecent opened this issue Jun 22, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@fulldecent
Copy link
Contributor

A contrived example is used at developers/fundamentals/avm-concepts/initializable-fields/

I recommend that all examples be functional and informative. Contrived examples give the appearance that the documenter does not fully understand the value of the thing being demonstrated.

If you cannot find a real example to demonstrate the documented feature then REMOVE THE FEATURE!

Be creative! When I was writing the NatSpec documentation for Solidity, this was an excuse to go learn a little bit about botany. Software documentation exists to help our dear customers go build things that matter to them, not demonstrate our mastery of computer science concepts :-p

@fulldecent fulldecent added the bug Something isn't working label Jun 22, 2019
@johnnymatthews
Copy link
Contributor

This issue has been added into the current sprint and will be address in the next two weeks.

@johnnymatthews johnnymatthews self-assigned this Aug 7, 2019
@johnnymatthews
Copy link
Contributor

A change has been submitted to address this issue: 97f53fd

@fulldecent
Copy link
Contributor Author

The example was updated to show somebody passing an API key through a web service.

🙅‍♂

Here is a specimen of a well-documented example code:

https://solidity.readthedocs.io/en/v0.5.11/natspec-format.html?highlight=Natspec

@johnnymatthews
Copy link
Contributor

Looks like we don't quite understand your issue then. Please suggest an example, or even make a PR if you have the time.

@johnnymatthews johnnymatthews removed their assignment Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants