Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing benchmark for less common operations #1323

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 18, 2024

There were a few methods still missing benchmarks, but since Home Assistant never calls them in production I never saw them in the profile and didn't think about writing benchmarks for them

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 18, 2024
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #1323 will not alter performance

Comparing benchmarks_missed (fd012d9) with master (fcb8d7c)

Summary

✅ 76 untouched benchmarks

🆕 3 new benchmarks

Benchmarks breakdown

Benchmark master benchmarks_missed Change
🆕 test_url_hash N/A 703.5 µs N/A
🆕 test_url_with_name N/A 1 ms N/A
🆕 test_url_with_path_parent N/A 1 ms N/A

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (fcb8d7c) to head (fd012d9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.01%     
==========================================
  Files          27       27              
  Lines        5382     5401      +19     
  Branches      326      329       +3     
==========================================
+ Hits         5164     5183      +19     
  Misses        192      192              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.96% <100.00%> (+0.01%) ⬆️
MyPy 44.59% <47.36%> (+0.01%) ⬆️
OS-Linux 99.31% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.37% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.04% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.02% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.02% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.22% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.27% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.30% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.04% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.31% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.37% <100.00%> (+<0.01%) ⬆️
pytest 99.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 18, 2024 00:46
@bdraco bdraco merged commit 6601ba5 into master Oct 18, 2024
43 of 46 checks passed
@bdraco bdraco deleted the benchmarks_missed branch October 18, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant