From bc4a0aa6e4f6edd78fbbad0078939df098d721ba Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 4 Sep 2024 15:46:59 -1000 Subject: [PATCH 1/3] Fix non-subscriptable MultiDictProxy with old multidict fixes #1105 --- yarl/_url.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/yarl/_url.py b/yarl/_url.py index b32856bc2..5bfb5ab28 100644 --- a/yarl/_url.py +++ b/yarl/_url.py @@ -640,7 +640,7 @@ def path(self) -> str: return self._PATH_UNQUOTER(self.raw_path) @cached_property - def query(self) -> MultiDictProxy[str]: + def query(self) -> "MultiDictProxy[str]": """A MultiDictProxy representing parsed query parameters in decoded representation. From 46b61d740db0719a2a4e5e15cb73a5c95d6eaf1e Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 4 Sep 2024 15:50:58 -1000 Subject: [PATCH 2/3] changelog --- CHANGES/1084.bugfix.rst | 1 + CHANGES/1105.bugfix.rst | 1 + CHANGES/1107.bugfix.rst | 3 +++ 3 files changed, 5 insertions(+) create mode 120000 CHANGES/1084.bugfix.rst create mode 120000 CHANGES/1105.bugfix.rst create mode 100644 CHANGES/1107.bugfix.rst diff --git a/CHANGES/1084.bugfix.rst b/CHANGES/1084.bugfix.rst new file mode 120000 index 000000000..95481dfbb --- /dev/null +++ b/CHANGES/1084.bugfix.rst @@ -0,0 +1 @@ +1107.bugfix.rst \ No newline at end of file diff --git a/CHANGES/1105.bugfix.rst b/CHANGES/1105.bugfix.rst new file mode 120000 index 000000000..95481dfbb --- /dev/null +++ b/CHANGES/1105.bugfix.rst @@ -0,0 +1 @@ +1107.bugfix.rst \ No newline at end of file diff --git a/CHANGES/1107.bugfix.rst b/CHANGES/1107.bugfix.rst new file mode 100644 index 000000000..d09bb6b2e --- /dev/null +++ b/CHANGES/1107.bugfix.rst @@ -0,0 +1,3 @@ +Fixed compatibility with ``multidict`` versions where ``MultiDictProxy`` is not a ``Generic`` -- by :user:`bdraco`. + +A :exc:`TypeError` would be raised in this case. From 542f7ca8961c8d0e9bdd39b1464d47a92d396649 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 4 Sep 2024 15:53:46 -1000 Subject: [PATCH 3/3] >4 is required so its only a python 3.8 problem --- CHANGES/1107.bugfix.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGES/1107.bugfix.rst b/CHANGES/1107.bugfix.rst index d09bb6b2e..4f70798b8 100644 --- a/CHANGES/1107.bugfix.rst +++ b/CHANGES/1107.bugfix.rst @@ -1,3 +1 @@ -Fixed compatibility with ``multidict`` versions where ``MultiDictProxy`` is not a ``Generic`` -- by :user:`bdraco`. - -A :exc:`TypeError` would be raised in this case. +Fixed a :exc:`TypeError` with ``MultiDictProxy`` and Python 3.8 -- by :user:`bdraco`.