Avoid running the workflow twice on PR pushes #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
force-pushed
the
avoid-double-runs
branch
from
c5de2b3 to
b4e1fe8
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 4 4
Lines 750 750
Branches 170 170
=======================================
Hits 748 748
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mjpieters
force-pushed
the
avoid-double-runs
branch
from
b4e1fe8 to
f348ac7
Compare
When someone force-pushes to a PR or adds a new commit, the workflow would run _twice_, as both `push` and `pull_request` events would trigger. The default for `types` is `[opened, reopened, synchronize]`; the latter is the type that overlaps with `push`. In addition, existing runs for the same PR are cancelled whenever a push is made.
mjpieters
force-pushed
the
avoid-double-runs
branch
from
f348ac7 to
58bc59b
Compare
q0w
pushed a commit
to q0w/yarl
that referenced
this pull request
Mar 29, 2022
When someone force-pushes to a PR or adds a new commit, the workflow would run _twice_, as both `push` and `pull_request` events would trigger. The default for `types` is `[opened, reopened, synchronize]`; the latter is the type that overlaps with `push`. In addition, existing runs for the same PR are cancelled whenever a push is made.
Important clarification: this only applies to PRs from within the upstream repo, which is why adopted a practice of making forks even where I have a commit bit. This is what we also enforce at Ansible… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone force-pushes to a PR or adds a new commit, the workflow would run
twice, as both
pushandpull_requestevents would trigger.The default for
typesis[opened, reopened, synchronize]; the latter is thetype that overlaps with
push.