Require typing_extensions for py<3.8 only #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
All the names imported from typing_extensions are available already in Python 3.8, so there is no need to use the additional dependency there. Furthermore, typing_extensions currently do not support Python 3.9, effectively blocking yarl from doing so. To solve this, use external typing_extensions only for py<3.8, and just use builtin typing in 3.8+.
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 4 4
Lines 708 708
Branches 157 157
=======================================
Hits 705 705
Misses 3 3 Continue to review full report at Codecov.
|
webknjaz
approved these changes
Jul 27, 2020
|
@mgorny thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
They make it possible to run on py3.8+ without external
typing_extensions. This also fixes support for py3.9 where typing_extensions don't work (yet).Are there changes in behavior for the user?
Nope.
Related issue number
Nope.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.