Fix doc building #812
Merged
Fix doc building #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aio-libs#804 removed the `aiokafka.protocol.produce` stubs imported from `kafka-python`, this caused the documentation to fail to build.
|
This pull request introduces 4 alerts when merging fb0bfad into 625f046 - view on LGTM.com new alerts:
|
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
multani
force-pushed
the
fix-doc-building
branch
from
fb0bfad to
d278a96
Compare
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
==========================================
- Coverage 97.96% 97.87% -0.10%
==========================================
Files 31 29 -2
Lines 5266 5220 -46
==========================================
- Hits 5159 5109 -50
- Misses 107 111 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request introduces 4 alerts when merging d278a96 into 625f046 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.