Fix warnings #810
Merged
Fix warnings #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
==========================================
- Coverage 97.89% 97.87% -0.02%
==========================================
Files 31 31
Lines 5358 5365 +7
==========================================
+ Hits 5245 5251 +6
- Misses 113 114 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request fixes 4 alerts when merging 451d045 into dc53097 - view on LGTM.com fixed alerts:
|
tvoinarovskyi
approved these changes
Dec 29, 2021
| await self._do_sasl_handshake() | ||
| if self._security_protocol in ["SASL_SSL", "SASL_PLAINTEXT"]: | ||
| await self._do_sasl_handshake() | ||
| except: # noqa: E722 |
There was a problem hiding this comment.
Please change this to except Exception, I would prefer not to have an implicit catch on BaseException if there is no need for it.
There was a problem hiding this comment.
We do need to catch BaseException. Actually I stepped into the problem with CancelledError, which nowadays doesn't inherit from Exception.
multani
added a commit
to multani/aiokafka
that referenced
this pull request
Dec 31, 2021
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
multani
added a commit
to multani/aiokafka
that referenced
this pull request
Dec 31, 2021
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
multani
added a commit
to multani/aiokafka
that referenced
this pull request
Dec 31, 2021
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
multani
added a commit
to multani/aiokafka
that referenced
this pull request
Dec 31, 2021
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
multani
added a commit
to multani/aiokafka
that referenced
this pull request
Dec 31, 2021
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
multani
added a commit
to multani/aiokafka
that referenced
this pull request
Dec 31, 2021
aio-libs#810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
ods
pushed a commit
that referenced
this pull request
Dec 31, 2021
* Fix doc building #804 removed the `aiokafka.protocol.produce` stubs imported from `kafka-python`, this caused the documentation to fail to build. * Fix RTD doc compilation #810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixe various warnings (ResourceWarning, DeprecationWarning).
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.